Request and track a code review

You can request a review in P4 Code Review for a shelved changelist, and track its state, without leaving P4 One. P4 One connects to P4 Code Review using your existing login, so you do not require a separate P4 Code Review login.

Before you begin

Your workspace must be connected to a P4 Server and you must be signed in to it.

Your P4 Server must have a P4 Code Review server configured before you can request or view reviews from P4 One. Contact your P4 administrator if you need help configuring this connection. For more information, see P4 Code Review documentation.

Request a review

You can request a review for any shelved changelist that does not already have one.

  1. In the Shelves tab, find the shelved changelist to review.

  2. Click Request review.

  3. Optionally, choose one or more reviewers and add a comment.

  4. Click Request review to create the review.

    P4 One creates the review in P4 Code Review and opens it in your browser.

See review state and test results

After a changelist has an associated review, its card in the Shelves tab shows a review status badge and a test status badge.

For example:

A shelved changelist card showing a review status badge.

The following table describes each status.

Badge Status Description

Review status

Needs Review

No reviewer has approved the review.

Review status

Needs Revision

A reviewer has requested changes.

Review status

Approved

A reviewer has approved the review.

Review status

Rejected

A reviewer has rejected the review.

Review status

Archived

The review is no longer active.

Test status

Running

Automated tests for the review are in progress.

Test status

Passed

Automated tests for the review completed successfully.

Test status

Failed

Automated tests for the review did not complete successfully.

Click either badge to open the review in P4 Code Review for more detail, such as reading or replying to comments.

Unshelve a reviewed changelist

You can unshelve a changelist that another user has submitted for review, so that you can examine the files in your own workspace.

  1. In the Shelves tab, find the shelved changelist that has the review to examine.

  2. Click Unshelve.

    P4 One applies the shelved files to a new pending changelist in your workspace. To learn more about resolving conflicts during unshelve, see Unshelve a changelist.